<html>
<head><meta charset="utf-8"><title>Label switching for outsiders is hard · t-release/triage · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/index.html">t-release/triage</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html">Label switching for outsiders is hard</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="209159918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209159918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Lew <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209159918">(Sep 05 2020 at 03:50)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/73971#issuecomment-687250207">https://github.com/rust-lang/rust/pull/73971#issuecomment-687250207</a></p>



<a name="209159920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209159920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Lew <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209159920">(Sep 05 2020 at 03:50)</a>:</h4>
<p>:(</p>



<a name="209176635"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209176635" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209176635">(Sep 05 2020 at 12:52)</a>:</h4>
<p>i agree switching is difficult, I wonder if we could add some notes to the automated bors message on how to switch labels after pushing</p>



<a name="209176771"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209176771" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209176771">(Sep 05 2020 at 12:56)</a>:</h4>
<p>That's a really strange pr though <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="209176775"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209176775" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209176775">(Sep 05 2020 at 12:56)</a>:</h4>
<p>(deleted)</p>



<a name="209176780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209176780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209176780">(Sep 05 2020 at 12:56)</a>:</h4>
<p>It looks like they just kept adding more changes after the PR was approved</p>



<a name="209176797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209176797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209176797">(Sep 05 2020 at 12:57)</a>:</h4>
<p>there were conflicts as well, so the label wasn't wrong for the entire duration (authors don't know that reviewers often wait for conflicts to be resolved before reviewing them, so i guess that's another point for us on the process improvement )</p>



<a name="209222918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209222918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209222918">(Sep 06 2020 at 12:16)</a>:</h4>
<p><span class="user-mention silent" data-user-id="120823">DPC</span> <a href="#narrow/stream/242269-t-release.2Ftriage/topic/Label.20switching.20for.20outsiders.20is.20hard/near/209176635">said</a>:</p>
<blockquote>
<p>i agree switching is difficult, I wonder if we could add some notes to the automated bors message on how to switch labels after pushing</p>
</blockquote>
<p>this seems easy enough to add,  I think it's highfive that comments though</p>



<a name="209222924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209222924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209222924">(Sep 06 2020 at 12:16)</a>:</h4>
<p><a href="https://github.com/rust-lang/highfive/">https://github.com/rust-lang/highfive/</a></p>



<a name="209224441"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209224441" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209224441">(Sep 06 2020 at 12:55)</a>:</h4>
<p>that's the reviewer assignment. was referring to the conflicts message</p>



<a name="209235523"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209235523" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209235523">(Sep 06 2020 at 18:14)</a>:</h4>
<p><span class="user-mention silent" data-user-id="120823">DPC</span> <a href="#narrow/stream/242269-t-release.2Ftriage/topic/Label.20switching.20for.20outsiders.20is.20hard/near/209176797">said</a>:</p>
<blockquote>
<p>there were conflicts as well, so the label wasn't wrong for the entire duration (authors don't know that reviewers often wait for conflicts to be resolved before reviewing them, so i guess that's another point for us on the process improvement )</p>
</blockquote>
<p>Perhaps bors could add something to its merge conflicts message that notes that reviewers likely won't review until conflicts are resolved? By the way, where is the bors source code? I found <a href="http://github.com/graydon/bors">github.com/graydon/bors</a>, but it doesn't seem to have the merge conflicts message in <code>bors.py</code></p>



<a name="209235757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209235757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209235757">(Sep 06 2020 at 18:21)</a>:</h4>
<p>Ah, I found it: it's <a href="http://github.com/rust-lang/homu">github.com/rust-lang/homu</a></p>



<a name="209236138"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209236138" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209236138">(Sep 06 2020 at 18:31)</a>:</h4>
<p><span class="user-mention" data-user-id="120823">@DPC</span> Okay, opened <a href="https://github.com/rust-lang/homu/issues/101">rust-lang/homu#101</a></p>



<a name="209237670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209237670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209237670">(Sep 06 2020 at 19:14)</a>:</h4>
<p>thnks</p>



<a name="209243097"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209243097" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209243097">(Sep 06 2020 at 21:49)</a>:</h4>
<p><span class="user-mention" data-user-id="307537">@Camelid</span> can you add a note on how to change the labels using rustbot once the conflicts are resolved?</p>



<a name="209245530"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209245530" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209245530">(Sep 06 2020 at 23:00)</a>:</h4>
<p><span class="user-mention" data-user-id="120823">@DPC</span> Done!</p>



<a name="209330676"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209330676" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209330676">(Sep 07 2020 at 22:15)</a>:</h4>
<p>opened an issue for this, <span class="user-mention" data-user-id="307537">@Camelid</span>'s PR (thanks!) only shows it for rebase conflicts: <a href="https://github.com/rust-lang/rustc-dev-guide/issues/855">https://github.com/rust-lang/rustc-dev-guide/issues/855</a></p>



<a name="209957390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/209957390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#209957390">(Sep 14 2020 at 00:54)</a>:</h4>
<p>I just saw this in my notifications, which was a pleasant surprise:</p>
<p><a href="/user_uploads/4715/-iTcaRFuOd20Swz9FsDUeOdo/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/-iTcaRFuOd20Swz9FsDUeOdo/image.png" title="image.png"><img src="/user_uploads/4715/-iTcaRFuOd20Swz9FsDUeOdo/image.png"></a></div>



<a name="211798390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242269-t-release/triage/topic/Label%20switching%20for%20outsiders%20is%20hard/near/211798390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/242269-t-release/triage/topic/Label.20switching.20for.20outsiders.20is.20hard.html#211798390">(Sep 30 2020 at 18:03)</a>:</h4>
<blockquote>
<p>Note that reviewers usually do not review pull requests until merge conflicts are resolved</p>
</blockquote>
<p>It would be much closer to the truth to shorten this to just "Note that reviewers usually do not review".<br>
Merge conflicts play secondary role in that.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>